Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TextSearchResource #513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kartikpaliwal
Copy link
Contributor

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: The pull request involves refactoring the text search functionality within the application. It includes the removal of the TextSearchResource class and associated error handling, as well as the corresponding route setup in the bootstrap file. Additionally, the test cases related to text search have been removed, indicating a significant change in how text search is handled in the application.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the removal of the TextSearchResource and its associated error handling is part of a planned refactoring and that any new or modified functionality is covered by appropriate tests.
  • Confirm that the removal of the text search route does not leave any dead code or unused dependencies in the codebase.
  • Verify that the refactoring does not negatively impact the user experience and that any changes to the text search functionality are communicated to the users, if necessary.
  • Review the application's documentation and update it to reflect the changes made to the text search functionality.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

ebl/corpus/web/texts.py Show resolved Hide resolved
Copy link

codeclimate bot commented Jan 29, 2024

Code Climate has analyzed commit 0ee656b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (75% is the threshold).

This pull request will bring the total coverage in the repository to 91.4% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant