ENG-125708: Added level to dialog with header text #969
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Issue:
When Dialog was opening at that time the header text is in
span
tag and not assigned withrole: heading
&aria-level
Solution:
If header text is present then
role: heading aria-level:2
will be added to header textGITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-125708
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Steps To Reproduce:
Modal will open-> inspect the heading text of Modal
Go to URL: https://stage.eightfold.ai/careers?domain=eightfolddemo-indhumathi.com