Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-125708: Added level to dialog with header text #969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sghosh-c-eightfold
Copy link
Contributor

SUMMARY:

Issue:

When Dialog was opening at that time the header text is in span tag and not assigned with role: heading & aria-level

Solution:

If header text is present then role: heading aria-level:2 will be added to header text

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-125708

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Steps To Reproduce:

  1. Open the URL - PCS Logged out - Career site
  2. Select any of the job and Apply
  3. Upload Resume

Modal will open-> inspect the heading text of Modal

Go to URL: https://stage.eightfold.ai/careers?domain=eightfolddemo-indhumathi.com

Screenshot 2025-03-20 at 1 17 42 PM

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (67f85d7) to head (7d59d1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files        1103     1103           
  Lines       20560    20561    +1     
  Branches     7780     7781    +1     
=======================================
+ Hits        17361    17362    +1     
  Misses       3111     3111           
  Partials       88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant