Task Hierarchy: drag-and-drop task from one part of the hierarchy to another #37
Conversation
…sed task creation date on sorting
There was a problem hiding this comment.
Please make these tweaks @4xdk and then I think we're good 👍 . Let's both look at how often these functions are run, but I think the lodash.debounce fixes the original issue from before. Thanks!
src/reducers/tasksReducer.js
Outdated
| ); | ||
| const newSubtaskGids = [...newParentTask.subtask_gids, taskGid]; | ||
| const newSubtasks = newSubtaskGids.filter( | ||
| (gid, idx) => newSubtaskGids.indexOf(gid) === idx |
There was a problem hiding this comment.
Every subtask gid has the same index as itself... or am I reading this wrong?
There was a problem hiding this comment.
Reading well ... I'll remove this bit.
| @@ -1,6 +1,8 @@ | |||
| import React, { Component } from 'react'; | |||
| import { connect } from 'react-redux'; | |||
| import { BrowserRouter as Router, Route, Switch } from 'react-router-dom'; | |||
| import { DragDropContext } from 'react-dnd'; | |||
| import HTML5Backend from 'react-dnd-html5-backend'; | |||
There was a problem hiding this comment.
Let's make sure there's no negative privacy repercussions here. Is HTML5 the only back end option that exists for this?
There was a problem hiding this comment.
Well, the only other one is the TouchBackend which doesn't seem to work using the mouse (one could say, obviously).
The thing is HTML5 backend doesn't work on touch devices (again, obviously).
I've checked the TouchBackend on iPhone6 (browserstack) and drag and drop seems to work ... sometimes. I guess it's and IOS issue: https://github.com/yahoo/react-dnd-touch-backend/issues/78. Although Android (Pixel 3) seemed to work even worse (I managed to delete some tasks trying to drag and drop 👎)
Anyway, if we're still up for it we could use https://louisbrunner.github.io/dnd-multi-backend/packages/react-dnd-multi-backend/
Quote: "HTML5toTouch starts by using the React DnD HTML5 Backend, but switches to the React DnD Touch Backend if a touch event is triggered. You application can smoothly use the nice HTML5 compatible backend and fallback on the Touch one on mobile devices!"
But as far as your original question goes re. privacy repercussions. No, I don't think we have any other backend option with react-dnd for desktop. Is HTML5 a privacy problem?
src/actions/index.js
Outdated
| @@ -24,6 +24,13 @@ import { | |||
| deleteMembershipReq, | |||
| } from '../api/memberships'; | |||
|
|
|||
| export const moveTask = (oldParentGid, newParentGid, taskGid) => ({ | |||
| type: 'MOVE_TASK', | |||
There was a problem hiding this comment.
How about MOVE_TASK_IN_HIERARCHY? Soon we may be reordering task lists in My Tasks
#2
Using the PR submitted at https://github.com/PursuanceProject/pursuance/pull/195/files as base.
Added the debounce (from lodash which btw. has a lot of nice functions I think would be nice to use all around) to limit canDrop calls as per: https://github.com/PursuanceProject/pursuance/pull/195/files#r197622886
And added the caching of parsed creation date as per: https://github.com/PursuanceProject/pursuance/pull/195/files#r197625840