Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure nested configs can be loaded from env file #4360

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

IMax153
Copy link
Member

@IMax153 IMax153 commented Jan 28, 2025

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Prior to this change, ConfigProvider.json would treat all nested configuration values as separated by nothing. However, in an env file a path and sequence delimiter may exist.

Related

  • Related Issue #
  • Closes #

@IMax153 IMax153 requested a review from tim-smart as a code owner January 28, 2025 20:25
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: b1a9aac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@effect/platform Patch
@effect/cli Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql Patch
@effect/ai Patch
@effect/ai-openai Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/cluster-browser Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IMax153 IMax153 force-pushed the fix/platform-config-provider branch from 247e1b3 to b1a9aac Compare January 28, 2025 20:35
@tim-smart tim-smart merged commit bb05fb8 into main Jan 29, 2025
12 checks passed
@tim-smart tim-smart deleted the fix/platform-config-provider branch January 29, 2025 04:25
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants