-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HashMap.tovalues #4317
Open
vinassefranche
wants to merge
3
commits into
Effect-TS:next-minor
Choose a base branch
from
vinassefranche:add-hashmap-tovalues
base: next-minor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add HashMap.tovalues #4317
vinassefranche
wants to merge
3
commits into
Effect-TS:next-minor
from
vinassefranche:add-hashmap-tovalues
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 16d6bc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
effect-bot
requested review from
gcanti,
tim-smart,
IMax153 and
mattiamanzati
as code owners
January 21, 2025 17:06
vinassefranche
force-pushed
the
add-hashmap-tovalues
branch
from
January 21, 2025 17:06
d944d54
to
16d6bc9
Compare
effect-bot
force-pushed
the
next-minor
branch
11 times, most recently
from
January 22, 2025 14:57
f8ef188
to
58d0262
Compare
effect-bot
force-pushed
the
next-minor
branch
4 times, most recently
from
January 23, 2025 11:45
2cb96fe
to
6bf15ff
Compare
effect-bot
force-pushed
the
next-minor
branch
12 times, most recently
from
January 28, 2025 10:12
bbe556f
to
df7f007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
This adds
HashMap.toValues()
that returns the values of aHashMap
as an array instead of as an iterator like is the case forHashMap.values()
I took inspiration from
entries
vstoEntries
for the naming. I don't know if there's another convention for this.Related