Limit the size of icyname and streamtitle when using an OLED display #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello Edzelf The length of the icyname and streamtitle provided by some Radio Stations is too big to be correctly show when using the supported OLED displays. This change limits the length of icyname to 42, and the streamtitle to 64 characters, when the user selects one of the supported OLED displays on the config.h Possibly this could be done in a better way, but it works. Rgs.
|
Hopefully ES accepts my big commit. It handles the overflow on tiny displays pretty gracefully. Figured I'd message you here if you want to take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Edzelf
The length of the icyname and streamtitle provided by some Radio Stations is too big to be correctly show when using the supported OLED displays. This change limits the length of icyname to 42, and the streamtitle to 64 characters, when the user selects one of the supported OLED displays on the config.h
Possibly this could be done in a better way, but it works.
Rgs.
Werk_AG