Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

538 warnings in reports #540

Merged
merged 2 commits into from
Jul 19, 2021
Merged

538 warnings in reports #540

merged 2 commits into from
Jul 19, 2021

Conversation

aloukina
Copy link
Collaborator

@aloukina aloukina commented Jul 19, 2021

This PR closes #536 and closes #538.

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #540 (45a8493) into main (dad6633) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          29       29           
  Lines        4187     4187           
=======================================
  Hits         3886     3886           
  Misses        301      301           
Impacted Files Coverage Δ
rsmtool/test_utils.py 68.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad6633...45a8493. Read the comment docs.

Copy link
Member

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@desilinguist desilinguist merged commit 5a2a293 into main Jul 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the 538-warnings-in-reports branch July 19, 2021 22:08
srhrshr pushed a commit to srhrshr/rsmtool that referenced this pull request Oct 23, 2021
…ingService/538-warnings-in-reports

538 warnings in reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if there are warnings in the reports and fix them if feasible Performance warning
2 participants