Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline the code for flagging warnings in the reports #539

Open
aloukina opened this issue Jul 19, 2021 · 0 comments
Open

Streamline the code for flagging warnings in the reports #539

aloukina opened this issue Jul 19, 2021 · 0 comments

Comments

@aloukina
Copy link
Collaborator

When tests are run in STRICT mode, we check for any errors or warnings in the report.

We currently have two functions:

test_utils.check_report https://github.com/EducationalTestingService/rsmtool/blob/main/rsmtool/test_utils.py#L767 checks for both errors and warnings

collect_warning_messages_from_report https://github.com/EducationalTestingService/rsmtool/blob/main/rsmtool/test_utils.py#L737 once again collects warning messages.

The warnings that are excluded under check_report would still be flagged as errors by collect_warning_messages_from_report.

We need to figure out why we have these two functions and streamline them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant