Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null dereference issues and improve error handling #1220

Merged
merged 5 commits into from
Feb 8, 2025

Conversation

lupino3
Copy link
Member

@lupino3 lupino3 commented Feb 8, 2025

Address potential null dereference scenarios, remove deprecated URL constructor, and enhance error handling by returning empty strings for invalid inputs.

Add more unit tests for FPInstructionUtils.

@lupino3 lupino3 enabled auto-merge (squash) February 8, 2025 14:48
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.53%. Comparing base (d03a42e) to head (34cb41d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/edumips64/ui/swing/GUIHelp.java 0.00% 4 Missing ⚠️
...ava/org/edumips64/core/fpu/FPInstructionUtils.java 50.00% 1 Missing ⚠️
.../org/edumips64/ui/swing/MultiLineBasicTableUI.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1220      +/-   ##
============================================
+ Coverage     52.38%   52.53%   +0.15%     
- Complexity     1459     1468       +9     
============================================
  Files           252      252              
  Lines         10210    10214       +4     
  Branches       1102     1102              
============================================
+ Hits           5348     5366      +18     
+ Misses         4541     4525      -16     
- Partials        321      323       +2     
Files with missing lines Coverage Δ
src/main/java/org/edumips64/core/IOManager.java 70.83% <100.00%> (ø)
src/main/java/org/edumips64/core/SymbolTable.java 49.05% <100.00%> (ø)
...rc/main/java/org/edumips64/core/parser/Parser.java 77.43% <ø> (ø)
...ava/org/edumips64/core/fpu/FPInstructionUtils.java 49.80% <50.00%> (+7.00%) ⬆️
.../org/edumips64/ui/swing/MultiLineBasicTableUI.java 0.00% <0.00%> (ø)
src/main/java/org/edumips64/ui/swing/GUIHelp.java 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d03a42e...34cb41d. Read the comment docs.

@github-actions github-actions bot temporarily deployed to 1220 February 8, 2025 14:51 Destroyed
@github-actions github-actions bot temporarily deployed to 1220 February 8, 2025 14:52 Destroyed
@lupino3 lupino3 merged commit aa3ca3c into master Feb 8, 2025
13 of 15 checks passed
@lupino3 lupino3 deleted the lupino3/fix-warnings branch February 8, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant