chore: use single target to support nv14/el18/pl18/pl18ev/nb4p #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
changed the title
pfeerick
added
compilation
richardclli
changed the title
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
3 times, most recently
from
353b5c3 to
f45e91e
Compare
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
2 times, most recently
from
d22f954 to
c1b4733
Compare
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
2 times, most recently
from
80e3a66 to
eb2040e
Compare
12 tasks
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
2 times, most recently
from
29e2bf2 to
6507fc1
Compare
|
@pfeerick Please check if the tap counting problem gone with this PR. |
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
3 times, most recently
from
d0a97c5 to
e55ceef
Compare
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
5 times, most recently
from
0596596 to
fe96973
Compare
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
2 times, most recently
from
464892b to
30049d2
Compare
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
from
30049d2 to
a9ac2fa
Compare
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
from
9011626 to
66af6be
Compare
Feel free to change this to something more suitable - it only prevents boot loader showing the RF USB entry as PI.10 is NC on the NV14
richardclli
force-pushed
the
fs_nv14_on_pl18
branch
from
321a7d4 to
c15ee04
Compare
|
@pfeerick I finally fixed the nv14 internal module, it is caused by a typo, haha. |
|
lol... ouch! no wonder it was hiding so well... it was just one teensy weensy extra letter where it wasn't wanted. Fantastic!!! I'll give it a spin shortly and hopefully merge :) |
|
Perfecto! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
pl18 target and nv14 target has a lot on common, unifying them into one target can easy maintenance in the future.
This PR is based on NB4+ PR, so the merge order is:
- [ ] nv14/el18 support in pl18 target PRThis branch just extend the pl18 target to handle 2 more PCBREV: nv14 and el18, i.e. one can still build nv14/el18 firmware using old target.
Old targets:
New targets: