Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Commit

Permalink
App won't launch due to version mismatch between Google Analytics and…
Browse files Browse the repository at this point in the history
… Google App Measurement #1061
  • Loading branch information
EddyVerbruggen committed Dec 8, 2018
1 parent 9a4b732 commit f782266
Show file tree
Hide file tree
Showing 7 changed files with 32 additions and 26 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
- [Firebase iOS SDK Changelog](https://firebase.google.com/support/release-notes/ios)
- [Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)

## 7.4.4 (2018, December 8)
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/85?closed=1)


## 7.4.3 (2018, December 3)
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/84?closed=1)

Expand Down
2 changes: 1 addition & 1 deletion demo-ng/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"nativescript-angular": "^6.1.0",
"nativescript-camera": "^4.0.2",
"nativescript-imagepicker": "~6.0.4",
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.3.tgz",
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.4.tgz",
"nativescript-theme-core": "~1.0.4",
"reflect-metadata": "~0.1.10",
"rxjs": "~6.0.0 || >=6.1.0",
Expand Down
2 changes: 1 addition & 1 deletion demo-push/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@
"build.plugin": "cd ../src && npm run build",
"ci.tslint": "npm i && tslint --config '../tslint.json' 'app/**/*.ts' --exclude '**/node_modules/**' --exclude '**/typings/**'"
}
}
}
2 changes: 1 addition & 1 deletion demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"dependencies": {
"firebase-functions": "^2.0.5",
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.3.tgz",
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-7.4.4.tgz",
"nativescript-theme-core": "^1.0.4",
"nativescript-unit-test-runner": "^0.3.4",
"tns-core-modules": "~5.0.5"
Expand Down
1 change: 1 addition & 0 deletions publish/scripts/installer.js
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ function writePodFile(result) {
(isPresent(result.ml_kit) ? `` : `#`) + `platform :ios, '9.0'
pod 'Firebase/Core', '~> 5.12.0'
pod 'GoogleAppMeasurement', '5.3' # temp fix for https://github.com/firebase/firebase-ios-sdk/issues/2151 (remove when bumping 'Firebase/Core')
# Authentication
` + (!isPresent(result.authentication) || isSelected(result.authentication) ? `` : `#`) + `pod 'Firebase/Auth'
Expand Down
2 changes: 1 addition & 1 deletion src/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nativescript-plugin-firebase",
"version": "7.4.3",
"version": "7.4.4",
"description": "Fire. Base. Firebase!",
"main": "firebase",
"typings": "index.d.ts",
Expand Down
45 changes: 23 additions & 22 deletions src/scripts/postinstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -2730,28 +2730,28 @@ function read (opts, cb) {
\***********************************/
/***/ (function(module, exports) {

module.exports = function(module) {
if(!module.webpackPolyfill) {
module.deprecate = function() {};
module.paths = [];
// module.parent = undefined by default
if(!module.children) module.children = [];
Object.defineProperty(module, "loaded", {
enumerable: true,
get: function() {
return module.l;
}
});
Object.defineProperty(module, "id", {
enumerable: true,
get: function() {
return module.i;
}
});
module.webpackPolyfill = 1;
}
return module;
};
module.exports = function(module) {
if(!module.webpackPolyfill) {
module.deprecate = function() {};
module.paths = [];
// module.parent = undefined by default
if(!module.children) module.children = [];
Object.defineProperty(module, "loaded", {
enumerable: true,
get: function() {
return module.l;
}
});
Object.defineProperty(module, "id", {
enumerable: true,
get: function() {
return module.i;
}
});
module.webpackPolyfill = 1;
}
return module;
};


/***/ }),
Expand Down Expand Up @@ -3131,6 +3131,7 @@ function writePodFile(result) {
(isPresent(result.ml_kit) ? `` : `#`) + `platform :ios, '9.0'
pod 'Firebase/Core', '~> 5.12.0'
pod 'GoogleAppMeasurement', '5.3' # temp fix for https://github.com/firebase/firebase-ios-sdk/issues/2151 (remove when bumping 'Firebase/Core')
# Authentication
` + (!isPresent(result.authentication) || isSelected(result.authentication) ? `` : `#`) + `pod 'Firebase/Auth'
Expand Down

0 comments on commit f782266

Please sign in to comment.