Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment for second PShelf item is broken #629

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Alignment for second PShelf item is broken #629

wants to merge 1 commit into from

Conversation

ShahzaibIbrahim
Copy link
Contributor

Alignment is broken for all n+1 items is broken because GC returns wrong height from the font metrics.

How to Test

Run the PShelfSnippet1 with the following VM Arguments on 200% monitor (Also happens for 100% but difference is not that much visible)

-Dswt.autoScale=quarter
-Dswt.autoScale.updateOnRuntime=true

See if the second item is properly aligned vertically.

Before Fix

image

After Fix

image

@ShahzaibIbrahim
Alignment for second PShelf item is broken
5545afb 
Alignment is broken for all n+1 items is broken because GC returns wrong
height from the font metrics.
@ShahzaibIbrahim ShahzaibIbrahim marked this pull request as draft January 15, 2025 13:50
@ShahzaibIbrahim ShahzaibIbrahim mentioned this pull request Jan 15, 2025
Open
@ShahzaibIbrahim ShahzaibIbrahim linked an issue Jan 15, 2025 that may be closed by this pull request
PShelf in Nebula not scaling during DPI Change vi-eclipse/Eclipse-Platform#145
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PShelf in Nebula not scaling during DPI Change
1 participant
@ShahzaibIbrahim