Replace usage of internal SWT TypedListener in CheckTableCombo #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverage new methods introduced in eclipse-platform/eclipse.platform.swt#1112
HannesWell
force-pushed
the
replace-typedListener-3
branch
from
2cfc2f9 to
213eccd
Compare
|
If @lcaron is not available @wimjongman could you please have a look at this? Once this is submitted, could you please consider to create a new release for Nebula as soon as possible, because in SWT we would like to make changes to actually internal classes that are not compatible with older versions of Nebula: |
|
Hi
I will have a look.
Take care
Laurent
Le mar. 26 nov. 2024 à 18:52, Hannes Wellmann ***@***.***> a
écrit :
… If @lcaron <https://github.com/lcaron> is not available @wimjongman
<https://github.com/wimjongman> could you please have a look at this?
Once this is submitted, could you please consider to create a new release
for Nebula as soon as possible, because in SWT we would like to make
changes to actually internal classes that are not compatible with older
versions of Nebula:
- eclipse-platform/eclipse.platform.swt#1615 (comment)
<eclipse-platform/eclipse.platform.swt#1615 (comment)>
—
Reply to this email directly, view it on GitHub
<#613 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI5UXRZWCS53RIE5D7ORAL2CSYOZAVCNFSM6AAAAABSMJVAFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBRGU4DOMJSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage new methods introduced in eclipse-platform/eclipse.platform.swt#1112
I somehow missed that part in my previous work to replace references to actually internal SWT classes in
@lcaron can you have a look at this as well. Thanks in advance.