Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify maven build workflow and update actions #584

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

HannesWell
Copy link
Contributor

Use the maven-caching integrated into the setup-java action to replace the explicit usage of actions/cache:
https://github.com/actions/setup-java/?tab=readme-ov-file#caching-maven-dependencies

Use the https://github.com/coactions/setup-xvfb instead of installing xvfb manually.

Run Maven in --batch-mode to suppress transfer print-out.

@lcaron
Copy link
Contributor

lcaron commented Mar 23, 2024

Very nice contribution, thank you very much @HannesWell :)

@HannesWell HannesWell force-pushed the simplify_maven_workflow branch from 03d255a to 397848d Compare March 24, 2024 14:17
Use the maven-caching integrated into the setup-java action to replace
the explicit usage of actions/cache:
https://github.com/actions/setup-java/?tab=readme-ov-file#caching-maven-dependencies

Use the https://github.com/coactions/setup-xvfb instead of installing
xvfb manually.

Run Maven in --batch-mode to suppress transfer print-out.
@HannesWell HannesWell force-pushed the simplify_maven_workflow branch from 397848d to 0297930 Compare March 26, 2024 19:31
@HannesWell
Copy link
Contributor Author

Very nice contribution, thank you very much @HannesWell :)

Thanks.
Is there anything missing or can this be submitted?

@merks merks merged commit 85a55cd into EclipseNebula:master Apr 10, 2024
3 checks passed
@HannesWell HannesWell deleted the simplify_maven_workflow branch April 10, 2024 11:29
@HannesWell
Copy link
Contributor Author

Thanks Ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants