Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-normalize line-endings in git of all files to Linux style ("\n") #581

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

HannesWell
Copy link
Contributor

Some ASCII-files were checked-in into git having windows style line endings (\r\n). This is in general not wanted because it can cause modified files without any difference in git-staging.

To re-normalize line endings of all files use the following command (including dot):
git add --renormalize .

@HannesWell
Copy link
Contributor Author

HannesWell commented Mar 22, 2024

Since there are a lot of files with many lines involved I wonder if this is really wanted or if windows line-endings are even desired.
At least it will make the git-blame useless for all affected file.

@lcaron
Copy link
Contributor

lcaron commented Mar 23, 2024

Thank you hannes for your contribution.
@wimjongman what do you think about merging this PR ?

Some ASCII-files were checked-in into git having windows style line
endings (\r\n). This is in general not wanted because it can cause
modified files without any difference in git-staging.

To re-normalize line endings of all files use the following command
(including dot):

git add --renormalize .
@HannesWell HannesWell force-pushed the renormalize-lineendings branch from 84dab01 to 0e1e561 Compare March 24, 2024 14:24
@wimjongman
Copy link
Contributor

Yes, let's go.

@lcaron lcaron merged commit 44150cc into EclipseNebula:master Mar 26, 2024
3 checks passed
@lcaron
Copy link
Contributor

lcaron commented Mar 26, 2024

PR Merged. Thank you @HannesWell for this nice contribution

@HannesWell HannesWell deleted the renormalize-lineendings branch March 26, 2024 19:31
@HannesWell
Copy link
Contributor Author

You are welcome and thank you for reviewing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants