Fix the Slider#computeSize method to take the real height into account #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the slider is displayed quite big compared to other SWT controls (e.g. labels) and even if one make the slider height smaller this does not really change much using the usual SWT layout managers. The reason for this is that the slider currently reports a minimum height of 40 instead of query the real selector height. This now reports the real height the control will be painted including a one pixel padding on top/bottom for antialiasing effects to be correctly shown.
|
Nice contribution, thank you @laeubi |
lcaron
approved these changes
May 26, 2024
I made a mistake while resolving the conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the slider is displayed quite big compared to other SWT controls (e.g. labels) and even if one make the slider height smaller this does not really change much using the usual SWT layout managers. The reason for this is that the slider currently reports a minimum height of 40 instead of query the real selector height.
This now reports the real height the control will be painted including a one pixel padding on top/bottom for antialiasing effects to be correctly shown.