-
Notifications
You must be signed in to change notification settings - Fork 263
Add Qt extensions #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Qt extensions #869
Conversation
bc30b59
to
4dc0b87
Compare
Fixes: [VSCODEEXT-96](https://bugreports.qt.io/browse/VSCODEEXT-96)
4dc0b87
to
5627df5
Compare
@gbraad @temoto @maxandersen @kalin Ping. |
This won't work as-is. See my prior attempt (#856). First of all, publish-extensions will not be able to figure out on its own which extension exists in which repository. So at the absolute minimum Then, since there are multiple steps involved to build the extension in addition to standard Now, since you're the official maintainer, my understanding 1 is that it's more preferred that the extension is published by the maintainer itself. This will make the extension appears in the OpenVSX as published by (in this case) Qt rather than by OpenVSX as if it's done by publish-extension. It will also reduce a chance that publish-extension's build process gets out-of-sync with instructions in this repo. It seems to be easy to publish a pre-built But if you're unable to do that for any reason and need to use publish-extension, then feel free to take my code from #856 and modify it. In particular, it would be nice to modify the build of qt-core extension so that it downloads the (corresponding version of) signed qt-cli instead of building directly here. Footnotes
|
Thank you for your detailed explanation. I'm not sure I understand the process completely. According to this https://github.com/EclipseFdn/open-vsx.org/wiki/Auto-Publishing-Extensions, it seems okay to use Having
That can be implemented in the future, but some server stuff should be arranged first. It might be better to go with publishing vsix packages explicitly. |
Fixes: VSCODEEXT-96
I'm an official maintainer
Description
This PR adds Qt extensions to Open VSX Registry
As a company, we signed https://www.eclipse.org/legal/eca