Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Updates March2021 #134

Merged
merged 17 commits into from
Apr 9, 2021
Merged

Updates March2021 #134

merged 17 commits into from
Apr 9, 2021

Conversation

ariexi
Copy link
Contributor

@ariexi ariexi commented Mar 19, 2021

Signed-off-by: ariexi [email protected]

Some necessary updates

@netlify
Copy link

netlify bot commented Mar 19, 2021

Deploy preview for eclipsefdn-openadx ready!

Built with commit 355691d

https://deploy-preview-134--eclipsefdn-openadx.netlify.app

@ariexi ariexi requested a review from autumnfound March 19, 2021 11:26
@ariexi
Copy link
Contributor Author

ariexi commented Mar 19, 2021

@autumnfound, any idea on how to integrate twitter timelines and twitter buttons?
Thx!
Andy

@ariexi
Copy link
Contributor Author

ariexi commented Mar 25, 2021

@autumnfound, any idea on how to integrate twitter timelines and twitter buttons?
Thx!
Andy

@autumnfound, did you had the chance to have a look on my PR? ;-)
Thx!

@autumnfound
Copy link
Contributor

@autumnfound, any idea on how to integrate twitter timelines and twitter buttons?
Thx!
Andy

@autumnfound, did you had the chance to have a look on my PR? ;-)
Thx!

Looking at your attempts for timeline, I don't know why it wouldn't have worked...it looks pretty straightforward tbh. The button is just a reskin of how they do the timelines, so get that working and this one would be a piece of cake. I'm finishing some stuff up today, but I'll see if I can get this working today in a separate patch!

@autumnfound autumnfound merged commit 7182cc1 into EclipseFdn:master Apr 9, 2021
@autumnfound
Copy link
Contributor

Apologies for not merging, I hadn't realized you had removed the Twitter things originally, and then we hit end of quarter which was pretty busy for us. I looked it over again and it all looks good so I merged it! I think we need to look at Twitter stuff as a whole in the base theme, as it could be a useful addition!

@autumnfound
Copy link
Contributor

Here's the issue for tracking: EclipseFdn/hugo-solstice-theme#218

@ariexi ariexi deleted the UpdateMarch2021 branch May 20, 2021 12:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants