Repository navigation
Update Go test module dependencies - #333
Merged
Merged
Conversation
Co-Authored-By: Codex <agents@sprock.io>
Co-Authored-By: nevr-merge <agents@sprock.io>
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update direct Go test dependencies in the plugin and system test modules to their current compatible releases. Let
go getandgo mod tidyupdate checksums and indirect YAML dependencies.Updated direct requirements:
github.com/stretchr/testify(tests/plugins,tests/system)v1.11.1v1.12.1buf.build/gen/go/echotools/nevr-api/protocolbuffers/go(tests/system)v1.36.11-20260320084729-a3dfb29cd431.1v1.36.12-20260921215355-cae473b86bfc.2google.golang.org/protobuf(tests/system)v1.36.11v1.36.12Prediction: test behavior stays unchanged; generated
go.mod/go.sumupdates compile and repository verification remains green.Closes #329
Verification on this tip
GOTOOLCHAIN=local go list -m -u allintests/pluginsandtests/system— PASS; updated modules are current. The remaininggithub.com/golang/protobuf v1.5.0appears only in the graph, is not required by the main module (go mod why -m github.com/golang/protobufsays the module is not needed), and no repository Go source imports it.just test-plugins-groundtruth— PASS; external-repository source checks skip where their optional sibling worktrees are absent.just test-system-short— PASS; game/login integration tests skip in short mode or withoutEVR_GAME_DIR.govulncheck ./...intests/pluginsandtests/system— PASS; no vulnerabilities found.just verify— PASS before and after commit (verify: OK (mingw-release); post-commit run: 326 C++ and 165 Python tests).git diff --check— PASS.GOTOOLCHAIN=local go test ./...intests/plugins— NOT PASS in this checkout because the optionaldist/combat_mod.dll,dist/combat_2d.dll, and game_overrides/combat/manifest.jsonassets are absent. The documented ground-truth recipe passes.The baseline build and verify were run at
6cea8e3e684b2ec08ac462faa93c95e85210f98e; both passed. It emitted the existing Mesa EGL and invariant warnings. A cold build on this tip also surfaced MinGWwinsock2.hinclude-order warnings in unchanged C++ files; the dependency diff does not touch those files.Audit command corrections: the first
go list -m -u allran from the repository root and failed because there is no rootgo.mod; it passed from each module. The first advisory-check scope invocation placedGOTOOLCHAIN=localwhere systemd-run expected an executable; correctedenv GOTOOLCHAIN=local govulncheck ./...passed in both modules.Branch lifecycle: deleted when this PR merges or closes.