Skip to content

Update Go test module dependencies - #333

Merged
thesprockee merged 2 commits into
mainfrom
codex/329-go-deps
Oct 10, 2026
Merged

thesprockee merged 2 commits into
mainfrom
codex/329-go-deps

Conversation

@thesprockee

Copy link
Copy Markdown
Member

Summary

Update direct Go test dependencies in the plugin and system test modules to their current compatible releases. Let go get and go mod tidy update checksums and indirect YAML dependencies.

Updated direct requirements:

Module Before After
github.com/stretchr/testify (tests/plugins, tests/system) v1.11.1 v1.12.1
buf.build/gen/go/echotools/nevr-api/protocolbuffers/go (tests/system) v1.36.11-20260320084729-a3dfb29cd431.1 v1.36.12-20260921215355-cae473b86bfc.2
google.golang.org/protobuf (tests/system) v1.36.11 v1.36.12

Prediction: test behavior stays unchanged; generated go.mod/go.sum updates compile and repository verification remains green.

Closes #329

Verification on this tip

  • GOTOOLCHAIN=local go list -m -u all in tests/plugins and tests/system — PASS; updated modules are current. The remaining github.com/golang/protobuf v1.5.0 appears only in the graph, is not required by the main module (go mod why -m github.com/golang/protobuf says the module is not needed), and no repository Go source imports it.
  • just test-plugins-groundtruth — PASS; external-repository source checks skip where their optional sibling worktrees are absent.
  • just test-system-short — PASS; game/login integration tests skip in short mode or without EVR_GAME_DIR.
  • govulncheck ./... in tests/plugins and tests/system — PASS; no vulnerabilities found.
  • just verify — PASS before and after commit (verify: OK (mingw-release); post-commit run: 326 C++ and 165 Python tests).
  • git diff --check — PASS.
  • Full GOTOOLCHAIN=local go test ./... in tests/plugins — NOT PASS in this checkout because the optional dist/combat_mod.dll, dist/combat_2d.dll, and game _overrides/combat/manifest.json assets are absent. The documented ground-truth recipe passes.
  • No full game/client or non-short system test was run; required game assets and MCP harness are not present.

The baseline build and verify were run at 6cea8e3e684b2ec08ac462faa93c95e85210f98e; both passed. It emitted the existing Mesa EGL and invariant warnings. A cold build on this tip also surfaced MinGW winsock2.h include-order warnings in unchanged C++ files; the dependency diff does not touch those files.

Audit command corrections: the first go list -m -u all ran from the repository root and failed because there is no root go.mod; it passed from each module. The first advisory-check scope invocation placed GOTOOLCHAIN=local where systemd-run expected an executable; corrected env GOTOOLCHAIN=local govulncheck ./... passed in both modules.

Branch lifecycle: deleted when this PR merges or closes.

thesprockee and others added 2 commits October 10, 2026 02:38
Co-Authored-By: Codex <agents@sprock.io>
Co-Authored-By: nevr-merge <agents@sprock.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Go test module dependencies

1 participant