Repository navigation
ci: land the ci/defender-scan branch (merged with main; net diff empty) - #323
Closed
thesprockee wants to merge 4 commits into
Closed
thesprockee wants to merge 4 commits into
thesprockee wants to merge 4 commits into
Conversation
…ows runner (#75) Manual, off main, not part of the release, nothing signed. A Linux job builds the dist zip as build.yml does with no secrets (no keys embedded); a windows-latest job records Get-MpComputerStatus, runs MpCmdRun -Scan -ScanType 3 on the unzipped files with -DisableRemediation (0 clean, 2 found), and prints Get-MpThreatDetection. Runs on a push to this branch because GitHub dispatches workflow_dispatch only from the default branch. Co-Authored-By: nevr-runtime <agents@sprock.io>
Co-Authored-By: nevr-runtime <agents@sprock.io>
…ompiles (#75) src/abi/echovr.h included <Windows.h>. Ubuntu's MinGW headers are lowercase only and Linux file names are case-sensitive, so the GitHub build failed at the first file that includes it: "src/abi/echovr.h:4:10: fatal error: Windows.h: No such file or directory" (run 37144672862, job build). Arch's MinGW ships both spellings (/usr/x86_64-w64-mingw32/include/Windows.h), which is why local builds never saw it. It was the only wrongly-cased Windows header include outside src/legacy. just verify green. Co-Authored-By: nevr-runtime <agents@sprock.io> (cherry picked from commit b6ee831)
The workflow on main (defender-scan.yml, #75) supersedes this branch's earlier version; the lowercase <windows.h> include is already on main. Resolved the add/add conflict with main's file, so the net diff against main is empty. Co-Authored-By: Andrew Bates <a@sprock.io>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves
ci/defender-scan(3 commits that were on no PR) by mergingorigin/maininto it and landing it. Refs #75 (closed).What the CI scan job does
.github/workflows/defender-scan.yml(on main) builds the unsigned release zips on Linux (build-zip, no secrets, so no embedded keys), then on awindows-latestrunner (scan) unzips each, prints SHA256 of every file, runsMpCmdRun.exe -Scan -ScanType 3 -DisableRemediationover them, and records Defender's engine/signature versions and verdict (clean / threats found / scan error) in the job summary. It is a measurement, not a gate: manual (workflow_dispatch) or by editing the file in a PR; it is not part of the release.Net diff against main is empty
97f528fb,9f6dc683,36b11332) added an earlier version of that workflow that triggered on a push toci/defender-scan, and changed#include <Windows.h>to<windows.h>insrc/abi/echovr.h.defender-scan.yml(Measure Microsoft Defender's verdict on the release zip (CI, Windows runner) #75: pacman toolchain container,.vcpkg-commitpin,libCrypt32.a, per-zip scan and summary) — a superset.defender-scan.yml; I resolved it with main's file.git diff origin/main HEAD --statprints nothing. Merging this PR changes no file; it only records the branch in history so it can be deleted.Branch lifecycle: deleted when this PR merges or closes.
Verification
4ada3c03: cappedVCPKG_MAX_CONCURRENCY=6 CMAKE_BUILD_PARALLEL_LEVEL=6 systemd-run --user --scope -p MemoryMax=10G just verify->verify: OK (mingw-release), log/var/tmp/work-nevr-runtime/nevr-static/verify-defender.log.🤖 Generated with Claude Code