Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(contributing): Merge #5816 with #5752 Indonesian translation #6719

Merged
merged 16 commits into from
Feb 22, 2022
Merged

docs(contributing): Merge #5816 with #5752 Indonesian translation #6719

merged 16 commits into from
Feb 22, 2022

Conversation

davorpa
Copy link
Member

@davorpa davorpa commented Feb 13, 2022 •
edited
Loading

What does this PR do?

Improve repo

For resources

Description

Recover missing parts from translation from PR #5752 requested by @reskimulud

Why is this valuable (or not)?

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa added 🐛 BUG Confirmed bugs, normally at GitHub Pages 🗣️ translations Issues or PRs addresing translations 🗣️ locale:id Resources addressing "Indonesian" language labels Feb 13, 2022
@davorpa davorpa self-assigned this Feb 13, 2022
This was referenced Feb 13, 2022
Closed
Closed
@davorpa davorpa changed the title Merge #5752 Indonesian CONTRIBUTING translation docs(contributing): Merge #5816 with #5752 Indonesian translation Feb 13, 2022
davorpa added 13 commits February 13, 2022 10:15
@davorpa
Homogenize format & indent of code blocks
b3250b8 
- Format using fenced style.
- Well indent in those placed inside list enumerations.
- Simulate `Good` - `Bad` monospace double colon indent inside each one.

- Examples highlighting as `text-plain`. The `md, markdown` style doesn't work very well since blocks has mixed syntax.
- `check_urls` code block highlighted as `properties` style (key-value pair).

Solves markdownlint rules:
- MD040/fenced-code-language: Fenced code blocks should have a language specified
- MD046/code-block-style: Code block style [Expected: indented; Actual: fenced]
@davorpa
Homogenize check_urls=file_to_check
7ea940f
@davorpa
use "consistent" unordered list mark and ensure 4-spaces indent .edit…
9d9b155 
…orconfig param

Solves markdownlint rules:
MD004/ul-style: Unordered list style "consistent"
@davorpa
Move some punctuation just before any closing brackets after it
77dbcae
@davorpa
Apply headings 2-1 empty lines lint rule
2625005
@davorpa
Move anchor alias to inside list items there where an anchor alias `<…
2f72a70 
…a name="...">` is used near to each of those list items
@davorpa
fix missing anchor aliases
ec2e2c7 
specially ones about Guidelines and Formatting
@davorpa
Hack highlight IDE/Editors headings+HTML
cd517c1 
It apply the hack to highlight in IDE/Editors those headings with an anchor alias just before itself
@davorpa
Homogenize Pull Request acronym
e717014
@davorpa
YouTube trademark typos
0baaf54
@davorpa
filenames in monospace font
e61cdb6
@davorpa
literals/markup texts in monospace font
f35b8c3 
- `et al.`
- File extensions `.md`
- Protocols: `http`, `https`...
- Notes: LeanPub, require email, StackOverflow, in process, archived

trailing dots in that lines
@davorpa
Merge EbookFoundation#6700 upstream/main commit into docs/id/contribu…
5116de8 
…ting/merge-5752-and-5816

SHA:  7a8349a
@davorpa davorpa marked this pull request as ready for review February 13, 2022 15:36
@davorpa davorpa requested a review from a team February 13, 2022 15:36
@davorpa davorpa mentioned this pull request Feb 13, 2022
Closed
@LuigiImVector LuigiImVector added the 🚀 ready to merge LGTM. Waiting for final approval label Feb 13, 2022
@LuigiImVector LuigiImVector mentioned this pull request Feb 13, 2022
Merged
1 task
@davorpa davorpa linked an issue Feb 13, 2022 that may be closed by this pull request
Bad target url documenting fpb-lint.yml since CONTRIBUTINGs were moved to docs folder #6721
Closed
@eshellman
Copy link
Collaborator

what does <!----> do?

@davorpa
Copy link
Member Author

davorpa commented Feb 14, 2022

what does <!----> do?

See cd517c1 commit. It's a kind of makeup that hacks syntax highlight in IDE/Editors when HTML and Markdown is mixed to give precedence to this latest.

An example is worth a thousand words:
image

It's ok?

@eshellman
Copy link
Collaborator

isn't "name" deprecated for <a>? Perhaps better to do <span id="something></span> ?

@davorpa
Copy link
Member Author

davorpa commented Feb 14, 2022 •
edited
Loading

isn't "name" deprecated for <a>? Perhaps better to do <span id="something></span> ?

Only in HTML5, and the W3C says "obsolete": https://html.spec.whatwg.org/multipage/obsolete.html#obsolete-but-conforming-features. Anyway it works anyway

If change needs be addopted, name => id, I suggest to address it in other PR. There are a lot of them in other files, mainly in some markdown section headings (https://github.com/EbookFoundation/free-programming-books/search?o=desc&q=%22a+name%22&s=).

@davorpa davorpa linked an issue Feb 16, 2022 that may be closed by this pull request
docs: Homogenize governance (CoC, CONTRIBUTING & HOWTO) across files #6590
Closed
9 tasks
@davorpa
Copy link
Member Author

davorpa commented Feb 22, 2022

What more we need to go ahead with this PR?

@eshellman eshellman merged commit 47bc198 into EbookFoundation:main Feb 22, 2022
@davorpa davorpa mentioned this pull request Feb 23, 2022
Merged
2 tasks
@Avishri99 Avishri99 mentioned this pull request Oct 6, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuigiImVector LuigiImVector LuigiImVector approved these changes

Assignees

@davorpa davorpa

Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages 🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:id Resources addressing "Indonesian" language 🗣️ translations Issues or PRs addresing translations
Projects
None yet
Milestone
No milestone
3 participants
@davorpa @eshellman @LuigiImVector