Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the german howto and contribution files #5905

Merged
merged 5 commits into from
Oct 6, 2021
Merged

Improvements to the german howto and contribution files #5905

merged 5 commits into from
Oct 6, 2021

Conversation

FabianKielmann
Copy link
Contributor

@FabianKielmann FabianKielmann commented Oct 4, 2021 •
edited
Loading

What does this PR do?

Improve the repo by fixing some grammer and restructuring sentences in the german howto and contribution files. Resolves #5887.

Checklist:

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@FabianKielmann FabianKielmann changed the title Resolves #5887 Improvements to the german howto and contribution files Oct 4, 2021
@davorpa
Copy link
Member

davorpa commented Oct 4, 2021

Improvements over: #5684 #5720 #5819

@Squirkyy, @lupinitylabs it'd be great if could give me some feedback about

@davorpa davorpa added question Needs clarification by involved users / reviewers 👥 discussion This Repo is guided by its community! Let's talk! conflicts Conflict(s) need to be resolved labels Oct 4, 2021
lupinitylabs
lupinitylabs reviewed Oct 5, 2021
View reviewed changes
HOWTO-de.md Show resolved Hide resolved
CONTRIBUTING-de.md Outdated Show resolved Hide resolved
CONTRIBUTING-de.md Outdated Show resolved Hide resolved
@lupinitylabs
Copy link
Contributor

Good catches @FabianKielmann! Thanks for the contribution. 🎉

davorpa
davorpa requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update the new recent locales.

Restore align as suggested.

@davorpa davorpa self-requested a review October 5, 2021 11:22
@davorpa davorpa removed question Needs clarification by involved users / reviewers 👥 discussion This Repo is guided by its community! Let's talk! conflicts Conflict(s) need to be resolved labels Oct 5, 2021
@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Oct 5, 2021
@davorpa
Copy link
Member

davorpa commented Oct 5, 2021

thanks for the efforts made by both

@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit c54f7fa into EbookFoundation:master Oct 6, 2021
@davorpa davorpa added 🗣️ translations Issues or PRs addresing translations 🗣️ locale:de Resources addressing "German / Deutsch" language labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupinitylabs lupinitylabs lupinitylabs left review comments

@davorpa davorpa davorpa approved these changes

Assignees

@FabianKielmann FabianKielmann

Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:de Resources addressing "German / Deutsch" language 🗣️ translations Issues or PRs addresing translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement of the german (de) HOWTO file
4 participants
@FabianKielmann @davorpa @lupinitylabs @eshellman