Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added license notes to 3 books and added type of book (pdf) for one #11479

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

manvith12
Copy link
Contributor

@manvith12 manvith12 commented Oct 10, 2024

What does this PR do?

Add info based on #11355

For resources

Description

This PR adds license notes to the following books located at books:

  1. A Complete Guide to Standard C++ Algorithms
    License Line found on Page 4 of the PDF.
    "This work may be distributed and/or modified under the conditions of the CC-BY-NC-SA license."
    Added (CC-BY-NC-SA)

  2. C++ GUI Programming with Qt 3
    License Line found on Page 4 of the PDF.
    "This material may only be distributed subject to the terms and conditions set forth in the Open Publication License, v1.0 or later."
    Added (OPl)

  3. C++ Notes for Professionals
    License Line found on Page 19 of the PDF.
    "The content is written by the beautiful people at Stack Overflow. Text content is released under Creative Commons BY-SA."
    Added (CC BY-SA)

this pr also added info on type of book :

  1. C++ Language
    checked the book and added (HTML)

Why is this valuable (or not)?

This information clarifies the licensing for these resources, ensuring users understand the terms under which they can use, modify, and distribute the content.

How do we know it's really free?

The licenses clearly state that the materials can be used freely within the specified conditions, which aligns with the principles of open educational resources.

For book lists, is it a book? For course lists, is it a course? etc.

It's a book.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

book 1 - A Complete Guide to Standard C++ Algorithms
license: CC-BY-NC-SA
found "This work may be distributed and/or modified under the conditions of the CC-BY-NC-SA license" 
on page 4/116


book 2 - C++ GUI Programming with Qt 3
license: OPl
found "This material may only be distributed subject to the terms and conditions set forth in the
Open Publication License, v1.0 or later"
on page 4/464


book 3 - C++ Notes for Professionals
license: CC BY-SA
found " the content is written by the beautiful people at Stack Overflow.
Text content is released under Creative Commons BY-SA"
on page 19/708
Copy link

Linter failed, fix the error(s):

free-programming-books/books/free-programming-books-langs.md
515:1-556:190  warning  Alphabetical ordering: swap l.523 and l.522  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 10, 2024
@manvith12
Copy link
Contributor Author

i dont understand whats the lint error , could anyone please explain

Copy link
Collaborator

@eshellman eshellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the extra space shoul satisfy the linter

books/free-programming-books-langs.md Outdated Show resolved Hide resolved
* [C++ GUI Programming With Qt 3](https://ptgmedia.pearsoncmg.com/images/0131240722/downloads/blanchette_book.pdf) - Jasmin Blanchette, Mark Summerfield (PDF)
* [C++ Language](http://www.cplusplus.com/doc/tutorial/)
* [C++ Notes for Professionals](https://goalkicker.com/CPlusPlusBook) - Compiled from StackOverflow Documentation (PDF)
* [C++ GUI Programming With Qt 3](https://ptgmedia.pearsoncmg.com/images/0131240722/downloads/blanchette_book.pdf) - Jasmin Blanchette, Mark Summerfield (PDF)(OPL)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPL is deprecated. We are not supporting it by adding license annotations.

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 11, 2024
Copy link

Linter failed, fix the error(s):

free-programming-books/books/free-programming-books-langs.md
515:1-556:190  warning  Alphabetical ordering: swap l.523 and l.522  alphabetize-lists  remark-lint

Copy link
Contributor Author

@manvith12 manvith12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the changes asked for

@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 14, 2024
@manvith12 manvith12 requested a review from eshellman October 14, 2024 08:58
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit 07b62fc into EbookFoundation:main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants