-
Notifications
You must be signed in to change notification settings - Fork 2
Feat: refresh token 재발급 #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ye-zin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 PR은 사용자 세션을 유지하고 빈번한 재인증을 방지하기 위해 리프레시 토큰 재발급 기능을 구현합니다.
Highlights
- 새로운 API 엔드포인트 추가: UserController에 리프레시 토큰 재발급을 위한 새로운 GET 엔드포인트 /user/refresh가 추가되었습니다.
- 리프레시 토큰 재발급 로직 구현: UserServiceImpl에 reissueRefreshToken 메서드가 추가되었습니다. 이 메서드는 들어오는 리프레시 토큰을 검증하고, 사용자 정보를 조회하며, 저장된 리프레시 토큰과 일치하는지 확인합니다. 또한, 새로운 액세스 토큰을 생성하고, 리프레시 토큰의 만료가 3일 이내인 경우 조건부로 새로운 리프레시 토큰을 재발급합니다.
- 토큰 타입 클레임 추가: JwtTokenProvider에서 생성되는 JWT에 tokenType 클레임("accessToken" 또는 "refreshToken")이 포함되도록 업데이트되었습니다.
- 토큰 유효성 검증 개선: JwtTokenProvider에 validateAccessToken, validateRefreshToken과 같은 별도의 유효성 검증 메서드 및 토큰에서 주체(getSubject)와 만료 시간(getExpriedTime)을 추출하는 메서드가 추가되었습니다.
- 새로운 DTO 정의: RefreshTokenResponseDTO가 도입되어 새로운 액세스 토큰, 리프레시 토큰 및 액세스 토큰 만료 시간을 캡슐화합니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이번 PR은 refresh token 재발급 기능을 추가하는 내용이네요. 전반적으로 기능 구현은 잘 되었지만, 몇 가지 개선점을 제안합니다. UserController의 불필요한 주석 제거와 API 경로 개선, UserServiceImpl의 동시성 문제 해결 및 매직 넘버 제거, 그리고 JwtTokenProvider의 JWT 파싱 효율성 개선 및 중복 코드 제거 등이 필요해 보입니다. 자세한 내용은 각 파일의 주석을 참고해주세요.
src/main/java/EatPic/spring/global/config/jwt/JwtTokenProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/EatPic/spring/domain/user/service/UserServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/EatPic/spring/domain/user/service/UserServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/EatPic/spring/domain/user/service/UserServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/EatPic/spring/global/config/jwt/JwtTokenProvider.java
Outdated
Show resolved
Hide resolved
2anizirong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳굳
#️⃣연관된 이슈
📝작업 내용
스크린샷