-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor: 검색 시 nickname, nameId으로 모두 검색 가능 #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @2anizirong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 PR은 계정 검색 기능을 개선하여 사용자가 닉네임과 nameId(사용자 ID)를 모두 사용하여 계정을 검색할 수 있도록 합니다. 이전에는 검색 범위에 따라 nameId 또는 닉네임 중 하나로만 검색이 가능했지만, 이제는 두 가지 기준으로 모두 검색할 수 있어 사용자 검색 경험이 향상됩니다.
Highlights
- 검색 기준 확장: 계정 검색 시 닉네임과 nameId를 모두 사용하여 검색할 수 있도록 기능이 확장되었습니다.
- API 문서 업데이트: /all/account 및 /user-follow/account 엔드포인트의 API 문서(Swagger) 설명이 업데이트되어 확장된 검색 기능을 반영합니다.
- 데이터베이스 쿼리 수정: UserRepository의 searchAccountInAll 및 searchAccountInFollow JPA 쿼리가 수정되어 검색 조건에 닉네임과 nameId를 모두 포함하도록 변경되었습니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 계정 검색 시 nickname과 nameId를 모두 사용하여 검색할 수 있도록 기능을 확장하는 좋은 리팩토링입니다. SearchController의 API 문서 업데이트와 UserRepository의 JPQL 쿼리 수정이 포함되었습니다. 다만, LIKE를 사용한 검색 쿼리의 성능에 대한 우려가 있습니다. 자세한 내용은 각 파일의 주석을 확인해주세요.
#️⃣연관된 이슈
📝작업 내용