Avoid interdependent content_title and page_title Twig blocks#7678
Open
MatTheCat wants to merge 1 commit into
Open
Avoid interdependent content_title and page_title Twig blocks#7678MatTheCat wants to merge 1 commit into
content_title and page_title Twig blocks#7678MatTheCat wants to merge 1 commit into
Conversation
MatTheCat
changed the title
MatTheCat
changed the title
content_title and page_title Twig blocks
Author
|
Not sure if that integrates correctly with @4d4ch4u32 could you confirm this work as expected with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Twig blocks rendering each other would create an infinite loop if none is overridden.
This PR moves
page_titleinsidecontent_titleso no need to manually render any of those.Fixes #7676