Fix lint error by reducing function complexity

EarthlingInteractive · Jul 31, 2018 · 2e109ad · 2e109ad
1 parent d016a35
commit 2e109ad
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/tutorial.js b/src/tutorial.js
@@ -47,17 +47,25 @@ AFRAME.registerComponent('tutorial', {
     },
 
     transition(prevStep, nextStep) {
-        if (prevStep !== undefined && prevStep >= 0 && this.tutorialSteps[prevStep]) {
-            this.tutorialSteps[prevStep].components['tutorial-step'].hide();
+        if (this.hasStep(prevStep)) {
+            this.getStep(prevStep).hide();
         }
-        if (nextStep < this.tutorialSteps.length && this.tutorialSteps[nextStep]) {
-            this.tutorialSteps[nextStep].components['tutorial-step'].show();
+        if (this.hasStep(nextStep)) {
+            this.getStep(nextStep).show();
         }
         if (!this.tutorialSteps[nextStep]) {
             this.handleStopTutorial();
         }
     },
 
+    getStep(index) {
+        return this.tutorialSteps[index].components['tutorial-step'];
+    },
+
+    hasStep(index) {
+        return (index !== undefined && index >= 0 && this.tutorialSteps[index]);
+    },
+
     handleStartTutorial() {
         this.startTutorialButton.setAttribute('visible', false);
         this.startTutorialButton.setAttribute('position', '-5 -0.5 -1');