fix(evolution): honor disabled planning rules in planner - #124
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(evolution): honor disabled planning rules in planner#124cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
evolution disable wrote disabled=true but PlanningRule dropped the field and the planner kept injecting the rule. Persist the flag and filter disabled rules from planner/beliefs consumption paths. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Record validation commands, mark TASK-2026-072 done, and sync the board. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skilllite evolution disable <rule_id>wrote"disabled": trueand reported success, butPlanningRulehad nodisabledfield and the planner kept injecting the rule into future plans/beliefs.PlanningRule.disabled, filter disabled rules from planner/beliefs consumption paths (not from seed merge loaders, to avoid write-back data loss), and add regression coverage.Trigger scenario
chat/prompts/rules.json.skilllite evolution disable <rule_id>and sees success.disabledand no consumer filtered it.Task Linkage
TASK-2026-072tasks/TASK-2026-072-evolution-disable-honored/Injected Specs
spec/verification-integrity.mdspec/task-artifact-language.mdspec/architecture-boundaries.mdspec/structured-signal-first.mdspec/capability-gap-evolution.mdspec/rust-conventions.mdspec/testing-policy.mdspec/docs-sync.md(N/A content change; corrects existing disable semantics)Validation Evidence
cargo fmt --checkcargo test -p skilllite-core planningcargo test -p skilllite-agent disabledcargo test -p skilllite-core -p skilllite-agent -p skilllite-evolution --libcargo clippy -p skilllite-core -p skilllite-agent -p skilllite-evolution --all-targets -- -D warningspython3 scripts/validate_tasks.py-D warnings71 task directories checkedDocs Sync
Regression Scope
--workspacefor disable/explainSKILL.mdname; MCPskill_namejoin without single-segment validationChecklist
cargo fmt --check-D warnings