OCPP 1.6 add schema validation checks on updates to custom keys #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a missing check on receipt of ChangeConfiguration.req for custom keys where a value could be set that would fail schema validation and prevent EVerest from successfully restarting. This update checks the new value before updating. Validation failures are noitfied to the CSMS via the ChangeConfiguration.conf Signed-off-by: James Chapman <[email protected]>
james-ctc
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
hikinggrass
requested changes
Nov 6, 2024
Signed-off-by: James Chapman <[email protected]>
hikinggrass
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
fix: add schema validation checks on updates to custom keysThere was a missing check on receipt of ChangeConfiguration.req for custom keys where a value could be set that would fail schema validation and prevent EVerest from successfully restarting.
This update checks the new value before updating.
Validation failures are noitfied to the CSMS via the ChangeConfiguration.conf
Issue ticket number and link
Checklist before requesting a review