Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log an explicit error when a wildcard server certificate is rejected #814

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Log an explicit error when a wildcard server certificate is rejected #814

merged 1 commit into from
Sep 30, 2024

Conversation

hikinggrass
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist before requesting a review

AssemblyJohn
AssemblyJohn approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@AssemblyJohn AssemblyJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cleared the errors that we can obtain the better, looks good!

@marcemmers marcemmers self-assigned this Sep 30, 2024
@hikinggrass hikinggrass merged commit e29affd into main Sep 30, 2024
4 checks passed
@hikinggrass hikinggrass deleted the feature/explicit-error-if-wildcard-certificate-is-rejected branch September 30, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcemmers marcemmers marcemmers approved these changes

@AssemblyJohn AssemblyJohn AssemblyJohn approved these changes

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@maaikez maaikez Awaiting requested review from maaikez maaikez is a code owner

Assignees

@marcemmers marcemmers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hikinggrass @AssemblyJohn @marcemmers