Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folkengine/k08 octt test failure #803

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

folkengine
Copy link
Contributor

Describe your changes

Unit test duplicating the OCTT integration test suite TC_K_41_CS test.

The CompositeSchedule test scenario is compromised of three zero stack level Profiles:

  • Absolute ChargingStationMaxProfile with a duration of 86404 and one
    chargingSchedulePeriod.
  • Absolute TxDefaultProfile with a duration of 304 and 5 periods.
  • Absolute TxProfile with a duration of 264 and 5 periods.
    It also includes the original log for the test.

While this test failed on its original run, it is passing against the current main branch. This could be because of several reasons:

  1. The run was against an earlier version of the code and the issue was fixed through our updates.
  2. The parameters passed in for the test are off so that it's a false positive.

Issue ticket number and link

issues/188

Checklist before requesting a review

Copy link

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I assume @Pietfried will run this against OCTT again once this is merged.

@folkengine folkengine marked this pull request as ready for review October 1, 2024 12:52
@Pietfried
Copy link
Contributor

LGTM! I assume @Pietfried will run this against OCTT again once this is merged.

TC_K_41_CS still fails but the reason for this is not composite schedule calculation. The issue is described here: #819 . With the suggested change described within the Anything Else? section of that issue, the test case passed.

Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this as a unit test!

lgtm except for the octt log which I would not check in.

@folkengine
Copy link
Contributor Author

Thanks for adding this as a unit test!

lgtm except for the octt log which I would not check in.

@Pietfried my pleasure. Changes made.

@Pietfried Pietfried merged commit c1d30ef into EVerest:main Oct 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants