-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Smart Charging Documentation v201 #800
base: main
Are you sure you want to change the base?
Updated Smart Charging Documentation v201 #800
Conversation
Signed-off-by: Coury Richards <[email protected]>
@shankari - this is ready for your review. |
README.md
Outdated
- `ChargingProfileFirstStartScheduleIsNotZero` | ||
|
||
The `startPeriod` of the first `chargingSchedulePeriod` needs to be 0. | ||
[K01.FR.31] | ||
|
||
- `ChargingProfileNoChargingSchedulePeriods` | ||
|
||
Happens when the `ChargingProfile` doesn't have any Charging Schedule | ||
Periods. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I don't think this should go into the README. I don't even think it should go into the architecture diagram. Instead, it should be a separate document so it can be linked to directly. From a formatting perspective, most error tables are ... tables and not lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shankari - just wanted to add a note here too. Do you have a preference on location. If not I was leaning towards the doc
directory.
I am fine with this location. However, I don't see the errors being formatted as tables
or any explanation of why the current formatting is better |
@shankari - updated the format to a table. |
c1b05ab
to
96c8d26
Compare
Describe your changes
Updated README.md to describe v201 of OCPPNote
Changes to documentation have been removed from this PR. An additional PR including these will be created.
Issue ticket number and link
Checklist before requesting a review