574 validate token #796
Draft
574 validate token #796
+36
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlitre
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
mlitre
force-pushed
the
574-validate-token
branch
from
845317a
to
dcbbe81
Compare
Removed references to get_vector_from_csv by split_string since this last method is more extensible / reusable. Signed-off-by: mlitre <[email protected]>
Method completely removed since we can just use the split_string method instead. Signed-off-by: mlitre <[email protected]>
Fixed edge cases concerning the two variables LocalPreAuthorize and LocalAuthorizeOffline. In some cases the cache was checked when offline even if LocalAuthorizeOffline was false. Signed-off-by: mlitre <[email protected]>
Verification of this configuration variable is also done for the Local Authorization List. Signed-off-by: mlitre <[email protected]>
We could send Authorize requests with an emaid token even though disable remote auth was true. Signed-off-by: mlitre <[email protected]>
mlitre
force-pushed
the
574-validate-token
branch
from
dcbbe81
to
1a7f07f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In this PR I've done several changes:
Todo:
Issue ticket number and link
Fixes issue #574
Checklist before requesting a review