Feature for SmartCharging Offline Behavior #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-ctc
reviewed
Sep 16, 2024
config/v201/component_config/standardized/SmartChargingCtrlr.json
Outdated
Show resolved
Hide resolved
| "IgnoredProfilePurposesOffline": { | ||
| "$comment": "Allows configuration of comma seperated list of ChargingProfilePurposes that are ignored in the composite schedule caluclation when offline.", | ||
| "type": "string", | ||
| "readOnly": true |
There was a problem hiding this comment.
Should the CSMS be allowed to update this?
| this->device_model->get_optional_value<std::string>(ControllerComponentVariables::IgnoredProfilePurposesOffline) | ||
| .value_or(""), | ||
| this->is_offline()); | ||
| return this->get_composite_schedule_internal(request, purposes_to_ignore); |
There was a problem hiding this comment.
is there an EVerest style guide covering the use of this->?
it is often needed in lambdas but here it shouldn't be needed.
There was a problem hiding this comment.
There is no such style guide (yet). Im coming from java (where this is required) and personally like it to explicitly mark the members.
There was a problem hiding this comment.
in a previous role member vars were prefixed with m_
Thank you for confirming there is no style guild. I have a PR where I was being asked to add this-> which at the moment is up to developer discretion.
…le in case the charging station is offline when the composite schedules are calculated by requests of a libocpp consumer application Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
* Made IgnoredProfilePurposesOffline ReadWrite * In OCPP1.6 calling signal_set_charging_profiles_callback also in case of websocket connect or disconnect in case IgnoredProfilePurposesOffline are empty, since this can influence the composite schedules * Fixed r/w of IgnoredProfilePurposesOffline in charge_point_configuration
Pietfried
force-pushed
the
feature/smart-charging-offline-behavior
branch
from
3e0a300
to
e977303
Compare
Signed-off-by: pietfried <[email protected]>
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added configuration variable to 1.6 and 2.0.1 to allow ignoring profile in case the charging station is offline when the composite schedules are calculated by requests of a libocpp consumer application
Issue ticket number and link
#781
Checklist before requesting a review