Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Updated test fixture names #782

Merged

Conversation

Giavotto
Copy link
Contributor

@Giavotto Giavotto commented Sep 9, 2024

Describe your changes

Renamed the test fixture for the SmartChargingHandler to SmartChargingHandlerTestFixtureV201

Renamed ChargePointFixture to ChargepointTestFixtureV201

Renamed ChargepointTestFixtureV201 to CompositeScheduleTestFixtureV201

Renamed K01_ValidateAndAdd_RejectsInvalidProfiles to K01_ValidateAndAdd_RejectsInvalidProfilesWithReasonCode

Small fix for database migrations in test_composite_schedule

Issue ticket number and link

Checklist before requesting a review

@Giavotto Giavotto force-pushed the giavotto/K01-refactor-test-fixture-names branch 2 times, most recently from 1e1678b to c6e5d81 Compare September 9, 2024 16:05
@Giavotto
Copy link
Contributor Author

Giavotto commented Sep 9, 2024

@shankari ready for review

Copy link

@shankari shankari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just have a few questions, but they are just for my curiosity and do not merit any changes.

…ng tested, additionally adjusted Schemas_Path in test_composite_schedule

Signed-off-by: Peter Giavotto <[email protected]>
@Giavotto Giavotto force-pushed the giavotto/K01-refactor-test-fixture-names branch from fa11455 to 0307a3e Compare September 17, 2024 13:47
Signed-off-by: Peter Giavotto <[email protected]>
@Giavotto Giavotto marked this pull request as ready for review September 20, 2024 15:08
@Pietfried Pietfried merged commit 9a9a9b9 into EVerest:main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants