cache network connection profiles #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNSubramanya
force-pushed
the
754-cache-ncp
branch
2 times, most recently
from
5d42967
to
02bd7ab
Compare
SNSubramanya
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
marcemmers
requested changes
Sep 11, 2024
| @@ -111,6 +112,8 @@ class ConnectivityManager { | |||
| bool send_to_websocket(const std::string& message); | |||
|
|
|||
| private: | |||
| /// @brief Local cached network connection profiles | |||
| std::vector<SetNetworkProfileRequest> network_connection_profiles; | |||
There was a problem hiding this comment.
We put the private variable at the top of the class ;)
| @@ -133,6 +130,9 @@ void ConnectivityManager::init_websocket() { | |||
| EVLOG_AND_THROW(std::runtime_error("ChargePointId must not contain \':\'")); | |||
| } | |||
|
|
|||
| // cache the network profiles on initialization | |||
| cache_network_connection_profiles(); | |||
|
|
|||
| const auto network_connection_priorities = ocpp::get_vector_from_csv( | |||
There was a problem hiding this comment.
The network configuration priority should also be part of this caching I assume?
| void ConnectivityManager::cache_network_connection_profiles() { | ||
|
|
||
| if (!this->network_connection_profiles.empty()) { | ||
| EVLOG_info << " Network connection profiles already cached"; |
There was a problem hiding this comment.
I would remove this print, does not tell anybody anything useful IMHO.
There was a problem hiding this comment.
i'll make it debug
SNSubramanya
force-pushed
the
754-cache-ncp
branch
2 times, most recently
from
f670d3e
to
500971c
Compare
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
754-cache-ncp
branch
2 times, most recently
from
81e67f7
to
623250e
Compare
Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
754-cache-ncp
branch
from
623250e
to
642d46b
Compare
marcemmers
approved these changes
Sep 12, 2024
couryrr-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Sep 13, 2024
added a function to cache network connection profiles and priorities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review