Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable CentralSystemURI for OCPP1.6 #393

Closed
wants to merge 1 commit into from
Closed

Configurable CentralSystemURI for OCPP1.6 #393

wants to merge 1 commit into from

Conversation

Pietfried
Copy link
Contributor

made CentralSystemURI of OCPP1.6 writable by CSMS. Change to this configuration key is applied only after reboot

@Pietfried
made CentralSystemURI of OCPP1.6 writable by CSMS. Change to this con…
2e9f9b4 
…figuration key is applied only after reboot

Signed-off-by: pietfried <[email protected]>
@Pietfried
Copy link
Contributor Author

Pietfried commented Feb 5, 2024 •
edited
Loading

  • Because it can cause loss of OCPP connectivity when this value is changed: Hide feature to write CentralSystemURI behind a separate configuration key
  • introduce config option to drop all persistent data (authorization cache, local auth list, pending transactions, not sure about smart charging profiles) when connecting to new CSMS

@Pietfried Pietfried added good first issue Good for newcomers OCPP1.6 labels Feb 5, 2024
@lategoodbye
Copy link

AFAIR implementing this feature in our stack wasn't trivial. Usually a change of the backend URI should drop all persistent data (authorization cache, local auth list, pending transactions, not sure about smart charging profiles) assigned to the old URI.

@Pietfried
Copy link
Contributor Author

AFAIR implementing this feature in our stack wasn't trivial. Usually a change of the backend URI should drop all persistent data (authorization cache, local auth list, pending transactions, not sure about smart charging profiles) assigned to the old URI.

Hi @lategoodbye , thanks for pointing this out. I added this to the further TODOs for this PR

@Pietfried
Copy link
Contributor Author

We decided to not merge it like that and probably use another approach to implement this feature

@Pietfried Pietfried closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass will be requested when the pull request is marked ready for review hikinggrass is a code owner

@maaikez maaikez Awaiting requested review from maaikez maaikez will be requested when the pull request is marked ready for review maaikez is a code owner

Assignees
No one assigned
Labels
good first issue Good for newcomers OCPP1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pietfried @lategoodbye