Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(EvseManager): use std::optional instead of pair #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(EvseManager): use std::optional instead of pair #881

wants to merge 1 commit into from

Conversation

a-w50
Copy link
Contributor

@a-w50 a-w50 commented Sep 26, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

SebaLukas
SebaLukas approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-w50
Copy link
Contributor Author

a-w50 commented Sep 26, 2024

Also have a look at this branch. Although its implementation is more complex, it scales better and should be less error prone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebaLukas SebaLukas SebaLukas approved these changes

@corneliusclaussen corneliusclaussen Awaiting requested review from corneliusclaussen corneliusclaussen is a code owner

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass is a code owner

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-w50 @SebaLukas