OCPP&OCPP201: explicitly handle all cases in switch statements #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikinggrass
requested review from
Pietfried,
maaikez and
corneliusclaussen
as code owners
Same. We should do the same for all code, in the long run. BTW, it also protects against changes in the enum declarations and missing them in some handling functions. |
corneliusclaussen
approved these changes
Oct 1, 2024
corneliusclaussen
added
the
include-in-release
Remove default: statements, turn on compiler error on enum conversion switch-case statements. This ensures that all cases are explicitly handled. This should also ensure that throw statements in the conversions functions are never be reached, they remain to prevent "control reaches end of non-void function" compiler warnings Signed-off-by: Kai-Uwe Hermann <[email protected]>
corneliusclaussen
force-pushed
the
feature/ocpp-non-throwing-enum-conversions
branch
from
f42780c
to
94bf654
Compare
corneliusclaussen
deleted the
feature/ocpp-non-throwing-enum-conversions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default: statements, turn on compiler error on enum conversion switch-case statements. This ensures that all cases are explicitly handled. This should also ensure that throw statements in the conversions functions are never be reached, they remain to prevent "control reaches end of non-void function" compiler warnings
Describe your changes
Issue ticket number and link
Checklist before requesting a review