PN532TokenProvider: Raise CommunicationFault instead of throwing exception #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikinggrass
requested review from
Pietfried and
corneliusclaussen
as code owners
barsnick
changed the title
corneliusclaussen
approved these changes
Oct 1, 2024
corneliusclaussen
added
the
include-in-release
Signed-off-by: Kai-Uwe Hermann <[email protected]>
corneliusclaussen
force-pushed
the
feature/pn532-error-handling
branch
from
2482baa
to
a000386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This replaces the exception that is thrown during initialization of the PN532TokenProvider if the serial port could not be accessed with an error.
TODO: Integration with Auth and/or EvseManager error handling. How do we want to handle this, do we want to perform periodic retries? If this error happens the module is non-functional afterwards
Issue ticket number and link
Checklist before requesting a review