Skip to content

Conversation

@shraddha-bajare
Copy link
Collaborator

Added quality indicator has_no_linting_issues to checkStyle JSON.

Fixes #150

Copy link
Contributor

@ebreitmo ebreitmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we start a new PR once the schema re 'helps measure' vs 'help indicator' will hav been updated?

Otherwise I think it is fine.

@shraddha-bajare
Copy link
Collaborator Author

Thanks for the quick look.
and it is a very good point @ebreitmo I feel we can have schema re 'helps measure' or 'help indicator' in the same PR.

I was away last week so might be missing some bits, are we expecting tools schema to be updated to include 'helps measure' or 'help indicator' ? perhaps question to @vuillaut :)

@npechl
Copy link
Contributor

npechl commented Nov 19, 2025

Hi, I also missed last week's call (I was attending a workshop). I approved the changes @shraddha-bajare feel free to merge if the PR is ready.

@vuillaut
Copy link
Contributor

Do we start a new PR once the schema re 'helps measure' vs 'help indicator' will hav been updated?

Otherwise I think it is fine.

Hi
Indeed, a second pass will be needed once this is sorted out....
But at the moment, this implementation respects the latest version of the schema, so you can move ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add indicators for checkstyle.json

5 participants