Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: determine legacy variant after determining compiler version #938

Merged

Conversation

drewr95
Copy link
Contributor

@drewr95 drewr95 commented Jul 30, 2024

Fixes the issue reported here: #937

Copy link

Review changes with SemanticDiff.

@drewr95 drewr95 closed this Jul 30, 2024
@drewr95 drewr95 reopened this Jul 30, 2024
@drewr95
Copy link
Contributor Author

drewr95 commented Jul 30, 2024

@jwellbelove what's the process for hotfixes like these? Will it get directly back into master or will it not be available until next release and sit in a feature branch? I don't like pointing at my own fork but will if it's needed

Thanks!

@jwellbelove
Copy link
Contributor

I am currently gathering up all of the features and hotfixes to release under a new release label.
If there are no last minute issues or bugs, then I will officially create a new release tomorrow morning.

@jwellbelove jwellbelove changed the base branch from master to development July 30, 2024 18:36
@jwellbelove jwellbelove merged commit 211b8c2 into ETLCPP:development Jul 30, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants