-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SAE J1850 CRC8 and "Zero" version #812
Merged
jwellbelove
merged 37 commits into
ETLCPP:pull-request/#812-Implement-SAE-J1850-CRC8
from
drewr95:feature/crc8_j1850
Jan 13, 2024
Merged
Implement SAE J1850 CRC8 and "Zero" version #812
jwellbelove
merged 37 commits into
ETLCPP:pull-request/#812-Implement-SAE-J1850-CRC8
from
drewr95:feature/crc8_j1850
Jan 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
Thanks, I'll merge that in shortly. |
jwellbelove
changed the base branch from
master
to
pull-request/#812-Implement-SAE-J1850-CRC8
January 13, 2024 11:48
jwellbelove
merged commit Jan 13, 2024
ac4c3e6
into
ETLCPP:pull-request/#812-Implement-SAE-J1850-CRC8
63 checks passed
jwellbelove
pushed a commit
that referenced
this pull request
Jan 18, 2024
jwellbelove
pushed a commit
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #811, I've recently needed to use the SAE J1850 CRC8 algorithm. I figured this would be a nice place to put it.
There is apparently a "Zero" version of the algorithm as well, of which I've included.