Skip to content

[WIP] QOL improvements in mksurfdata_esmf makefile #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: b4b-dev
Choose a base branch
from
Draft

[WIP] QOL improvements in mksurfdata_esmf makefile #3056

wants to merge 15 commits into from

Conversation

samsrabin
Copy link
Collaborator

WARNING: WORK IN PROGRESS. SUBJECT TO FORCE PUSHES

BLOCKED BY #2737

Description of changes

Adds two quality-of-life improvements in the Makefile for mksurfdata_esmf:

  • Error quickly if tool hasn't yet been built.
  • Look for project number in $PROJECT env variable before checking ~/.cesm_proj, standardizing on the CIME behavior.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed: None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: Tested as part of #2737.

samsrabin added 15 commits April 8, 2025 10:28
@samsrabin
Add subroutine for filling output arrays.
e07c199
@samsrabin
Put back commented-out organic_o option 2.
cd8072d
@samsrabin
Fixes to organic_o option 2.
1f5772e
@samsrabin
mksoiltex: Rename is_neg_4 to is_sand_dune.
a0c3c6e
@samsrabin
Remove organic_o option 2.
6f008d1
@samsrabin
Check sand for negative values.
415382d
@samsrabin
Check for negative values in organic_o.
fe2288b
@samsrabin
Improve mksurfdata_esmf .gitignore.
64bc086
@samsrabin
gen_mksurfdata_jobscript: Use ACCOUNT as default, falling back to P93…
05db3c3 
…300641.
@samsrabin
mksoiltex: Remove remaining unused 'option 2' code.
cddd069
@samsrabin
Improve 'Calculate organic' comment.
4dc79e8
@samsrabin
mksoiltex: Add description of mksoiltex_i_to_o().
501a596
@samsrabin
mksurfdata_esmf: Fix longitude for 1x1_brazil.
839ef6b
@samsrabin
mksurfdata_esmf: Error in Makefile if not built.
b7e3849
@samsrabin
mksurfdata_esmf: Check $PROJECT before ~/.cesm_proj.
6667c8a 
Standardizing on the behavior used by CIME.
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability blocked: dependency Wait to work on this until dependency is resolved bfb bit-for-bit labels Apr 8, 2025
@samsrabin samsrabin self-assigned this Apr 8, 2025
@samsrabin samsrabin added next this should get some attention in the next week or two. Normally each Thursday SE meeting. usability Improve or clarify user-facing options size: small test: mksurfdata Test mksurfdata_esmf before merging labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samsrabin samsrabin

Labels
bfb bit-for-bit blocked: dependency Wait to work on this until dependency is resolved enhancement new capability or improved behavior of existing capability next this should get some attention in the next week or two. Normally each Thursday SE meeting. size: small test: mksurfdata Test mksurfdata_esmf before merging usability Improve or clarify user-facing options
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsrabin