-
Notifications
You must be signed in to change notification settings - Fork 334
ctsm5.3.059: Various cleanup efforts from the cesm3_0_beta04 tags for testing and usability #2950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y fail as expected
…FATES, and also off when coupled to CAM
… initialization of the CNFireNorFire class
… initialization of the CNFireNorFire class
…file' into ne3np4_to_defaults_and_makefile
…efile slevis resolved conflicts: bld/unit_testers/build-namelist_test.pl
Bring back clm5-cam6 init_interp_attributes for ne0CONUS grid
…ts with 3d CAM using F2000climo with SROF
ctsm warm_start mods
…np4_to_defaults_and_makefile
…file ne3np4 to namelist_defaults_ctsm.xml and Makefile for PTS mode and add ability for warm starts in PTS mode
Fix PEM test for FATES testmod that builds an on-the-fly parameter file
I updated to ctsm5.3.057 and testing for aux_clm is passing as expected on Derecho and Izumi. |
branch with 5.3.05Y: Make sure FORTRAN code properly aborts when fire-emission is asked for and it can't be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reviewing the part of this that comes in with #2844 since the other PRs were mine.
The title of #2844 predisposed me to expect a short PR with few code changes. This turns out to be a major (in my perception) refactor, plus an addition of unit tests. Thank you for all this @ekluzek!
I included a few questions. Nothing stood out as problematic to me.
I ran some extra tests to make sure the issues were resolved. These PASS: PEA.1x1_smallvilleIA.IHistClm50BgcCropQianRs.derecho_gnu.clm-smallville_dynurban_monthly These fail and need to be figured out: ERS_Ld3.f19_f19_mg17.FXHIST.derecho_intel.cam-waccmx_weimer (SETUP) |
It looks like the problem with the f19 tests are the unusual RUN_STARTDATE of: 2005-12-31 and 2003-10-28. It fails with the problem we have been seeing where use_init_interp isn't coordinated correctly with the IC files. The ARCTIC grid fails in an ESMF regrid and I think it's likely due to too few processors. The default for CAM is 91 nodes, which is 11k tasks, so 10X larger than the tasks asked for. So I think it will likely work with more processors. |
Since, I had some variety of tests failing, I sent the ctsm_sci test list and these tests failed as they need the --clm-nofireemis added as an extra testmod to them. SMS_Ld5.f09_g17.IHistClm50SpCru.derecho_intel.clm-default (SETUP) |
In the meeting this morning, I was encouraged to make the tag as is. And file issues for anything outstanding. I have created baselines that just need to be renamed. And I'll start the ChangeLog. |
…s, adding SEQ and PEA tests, make sure the changes are for Clm60 tests
Some tests have different answers because the fieldlists change because fire-emission is off. ERP_D_Ld3_PS.f09_g17.I2000Clm50Sp.derecho_intel.clm-prescribed Also the ctsm_sci comparison to ctsm5.3.051 changes answers for VOC's because the MEGAN change came in just after that. |
Description of changes
Various updates for testing and other problems identified in the cesm3_0_beta04 tag. So fixes and cleanup for usability.
Including the following:
Specific notes
Contributors other than yourself, if any: @slevis-lmwg
CTSM Issues Fixed (include github issue #):
Fixes #2868
Fixes #2791
Fixes #2768
Fixes #2780
Fixes #2762
Fixes #3073
Some of #2810
CTSM namelist checking for: NGEET/fates#1356
Some work on #2643
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? Yes
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: regular
PR's Involved:
#2840
#2835
#2834
#2844