Skip to content

Commit

Permalink
Remove a colon from assign-to-project.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
@samsrabin
samsrabin committed Feb 1, 2024
1 parent 99bd601 commit 829da76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/assign-to-project.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
name: Assign to High Priority project
steps:
- name: Assign issues and pull requests with priority: high label to project 25
- name: Assign issues and pull requests with priority-high label to project 25
uses: srggrs/[email protected]
if: |
contains(github.event.issue.labels.*.name, 'priority: high') ||
Expand Down

6 comments on commit 829da76

@TeaganKing
Copy link
Contributor

@TeaganKing TeaganKing commented on 829da76 Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin it looks like there is an error in this line now when running GitHub Actions. See error below from one of my commits (on my personal branch).

[Invalid workflow file: .github/workflows/assign-to-project.yml#L16](https://github.com/TeaganKing/CTSM/actions/runs/7804055717/workflow)
You have an error in your yaml syntax on line 16

It also looks like I can't submit a PR with workflow changes, so I thought I'd just tag you. I'm not sure if it's the dash that's an issue now? Maybe putting this in quotes would help?

@samsrabin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh! Thanks for the heads up.

@ekluzek
Copy link
Contributor

@ekluzek ekluzek commented on 829da76 Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TeaganKing we brought an update on master (but not in any tags) that is working for me. I'm having to update my branches
to escomp/master and then it seems to fix the problem. Have you tried that? The one thing I find is that I have to do this with
any branch I work with, so the more branches I touch the more I have to update.

@ekluzek
Copy link
Contributor

@ekluzek ekluzek commented on 829da76 Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I put the corrected code on master in a YAML syntax checker it passes with the dash above.
One example is:

https://yamlchecker.com/

@TeaganKing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see! Sorry for the false alarm @samsrabin , and thanks for letting me know about that update @ekluzek !

@ekluzek
Copy link
Contributor

@ekluzek ekluzek commented on 829da76 Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I'd rather have a culture where everyone feels free to point out issues, than one where everyone is too afraid to do that!

Please sign in to comment.