cam6_4_090: GEOS-Chem 14.5 and dependencies#1247
Merged
lizziel merged 15 commits intoESCOMP:cam_developmentfrom May 1, 2025
Merged
cam6_4_090: GEOS-Chem 14.5 and dependencies#1247lizziel merged 15 commits intoESCOMP:cam_developmentfrom
lizziel merged 15 commits intoESCOMP:cam_developmentfrom
Conversation
This was referenced Mar 18, 2025
lizziel
force-pushed
the
feature/geoschem_14.5_and_dependencies
branch
from
92355a0 to
e2b7034
Compare
lizziel
force-pushed
the
feature/geoschem_14.5_and_dependencies
branch
2 times, most recently
from
1882564 to
426d179
Compare
fvitt
approved these changes
Apr 29, 2025
Collaborator
fvitt
left a comment
fvitt
left a comment
There was a problem hiding this comment.
Seems okay to me. The code changes are for GEOS-Chem only.
Can we expect the FCSD_HCO regression tests to pass with these updates?
Remember to update ChangeLog -- you have a nice description in the PR "Conversion" page.
Collaborator
Author
|
@fvitt - Yes, the FCSD_HCO regression tests should pass with this update. |
cacraigucar
changed the title
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…erties Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
feature/geoschem_14.5_and_dependencies
branch
2 times, most recently
from
4baf609 to
207c4ef
Compare
Collaborator
Author
|
I should clarify that I expect the HEMCO with CAM-chem results to be different compared to the previous tag. This is because of (1) a bug fix in HEMCO for 3D emissions regridding, and (2) an update to the ESMF call to regrid between the CAM and HEMCO grids for bit-for-bit reproducibility. Manual submission of tests within cime show that the restart and SMS tests now pass: The tag test suite shows differences in "BASELINE" which I assume is comparison to the previous tag. |
Member
|
Hi @lizziel, thanks for bringing this in! Yes a BASELINE fail means that the answers have changed compared to the previous tag. |
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
feature/geoschem_14.5_and_dependencies
branch
from
207c4ef to
a3b0386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the following externals:
All of these externals have their own Changelog listing changes between these versions. There is also more information per version accessible from the GEOS-Chem versions page, including benchmark results comparing GEOS-Chem 14.4 and 14.5.
The most notable changes are:
atm.lograther thancesm.logcamchem_hcotests (CAM-chem with HEMCO) passfixes #856, fixes #1018, fixes #1282
Note that GEOS-Chem will still fail restart tests. Updates to add additional arrays to the restart file (known issue) will be a separate PR.