cam6_4_007: CCPP-ized TJ2016 #1070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on in atmos_phys.
cacraigucar
approved these changes
Jun 28, 2024
cacraigucar
added this to Open PRs - unassigned
in CAM Development branch (cutting edge development)
via automation
nusbaume
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Looks good to me! Chatted with @mwaxmonsky offline about some nit-picky spacing stuff, but it shouldn't impact the results at all.
cacraigucar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving TJ2016 implementation to atmospheric_physics and updating needed using statements to include additional parameters for new run function APIs.