CCPP'ize dadadj #1026
CCPP'ize dadadj #1026
Conversation
… to redirect this to the tagged version
cacraigucar
added this to Open PRs - unassigned
in CAM Development branch (cutting edge development)
via automation
… name is in Filepath
Externals_CAM.cfg
Outdated
| @@ -50,9 +50,9 @@ tag = ALI_ARMS_v1.0.1 | |||
| required = True | |||
|
|
|||
| [atmos_phys] | |||
| tag = atmos_phys0_02_006 | |||
| branch = dadadj | |||
There was a problem hiding this comment.
Just adding the usual reminder to point to a tag once ESCOMP/atmospheric_physics#91 has been approved and merged.
There was a problem hiding this comment.
Thanks. Will do. Nice to know the order these things need to be done.
| call outfld('DADADJ_PD', dadpdf(:ncol,:), ncol, lchnk) | ||
|
|
||
| ! convert the t tendency to an s tendency for cam | ||
| ptend%s(:ncol,:) = ptend%s(:ncol,:) * cpairv(:ncol,:,lchnk) |
There was a problem hiding this comment.
@nusbaume - Just wanting to confirm our definition of tendency_of_air_temperature? Is it without out the cpairv adjustment? If so, we may want to augment the conversion document to indicate the ptend%s special adjustment?
There was a problem hiding this comment.
Yes, tendency_of_air_temperature is basically the change in state%t (or air temperature), while ptend%s is technically the tendency_of_dry_air_enthalpy_at_constant_pressure, which in CAM we use to calculate the change state%t in physics_update by dividing by cpairv. So in other words:
ptend%t = ptend%s / cpairv
or in standard name lingo:
tendency_of_air_temperature = tendency_of_dry_air_enthalpy_at_constant_pressure / composition_dependent_specific_heat_of_dry_air_at_constant_pressure
Hopefully that makes sense? If not just let me know. Regardless I can say that I am pretty sure this new CAM code is correct as-is.
Refactor dadadj parameterization for inclusion in the CCPP framework. On the CAM side this entails moving the core parameterization over to atmos_phys and updating the dadadj_cam interface file to call the new library routine. There are additional mods to cime and ccs_config that are needed for the CAM-SIMA dadadj CCPP validation.