-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worldcereal crop extent UDP #63
Conversation
Unit test is failing, because UDP namespace refers to a main branch URL (which will only exist after PR merge) EDIT: changed namespace URL again to feature branch to pass unit tests |
can we also support postprocess parameters as an additional argument in the UDP? |
I think not, as they are all client side if..else.. statements. Changing a postprocess parameter will just change your entire process graph. |
So in practice this means we need a whole batch of UDP's for each possible combination of postprocess parameters? |
I believe so; the backend would need to support something like conditional nodes in a process graph, but that seems like a very complicated feature. |
I think you can in fact use the openEO 'if' process at top level, to indeed switch your process graph based on a UDP parameter. Of course, we have to be careful and keep it sensible. For some cases, it is indeed really better to simply construct a library of different UDP's, with a clear set of parameters each, avoiding that one parameter depends on the value of other parameters. |
@VincentVerelst given that we have someone waiting for this, would it be safe to already merge this version, and then perhaps continue? (So does this graph work when we run it?) |
@jdries , yes the process graph in its current version is working.
|
UDP to generate WorldCereal crop extent.
Note: Currently it's not possible to parametrize the S1 orbit state; see Open-EO/openeo-python-driver#327
Usage example: